fix(parser): error on invalid operators in string interpolation#933
Merged
SchoolyB merged 1 commit intobugfixes/1-7-2026from Jan 7, 2026
Merged
Conversation
String interpolation was silently dropping expressions with invalid operators (&, |, ^), returning only the first operand. Now checks for lexer errors and unconsumed tokens after parsing interpolated expressions.
SchoolyB
added a commit
that referenced
this pull request
Apr 3, 2026
#933) String interpolation was silently dropping expressions with invalid operators (&, |, ^), returning only the first operand. Now checks for lexer errors and unconsumed tokens after parsing interpolated expressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
&,|,^), returning only the first operand instead of erroringparseInterpolatedExpression()to check for lexer errors and unconsumed tokensChanges
pkg/parser/parser.go: Added checks after parsing interpolated expressionsTest plan
${a & b}now errors: "& is not a valid binary operator in expressions"${a | b}now errors: "unexpected character '|', did you mean '||'?"${a ^ b}now errors: "illegal character '^' in expression"+,-,*,/) still work correctly